search

salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Split variables.scss into two files #83

Closed salcode closed 9 years ago

salcode commented 9 years ago

The variables.scss file has two purposes.

  1. To override Bootstrap default Sass variable values
  2. To set Sass variable values specific to Bootstrap Genesis

The problem occurs with when this file is loaded.

In the first case, if we want to override a Bootstrap variable, we should load our file before the Bootstrap Sass files.

In the second case, if we want to set a Bootstrap Genesis variable using a Bootstrap core variable (e.g. $widgetFontColor: $text-color), we should load our file after the Bootstrap Sass files.

Therefore, we should split variables.scss into variables-bootstrap-core-override.scss and variables-bootstrap-genesis.scss, loading the former before the Boostrap core Sass files and the later after the Bootstrap core Sass files.

See discussion in #72