salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
184 stars 63 forks source link

Default header can't be removed for landing pages? #86

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hi,

I am working with your child theme for a couple of days now but I can't manage to remove the header for a landing page. The genesis hooks below seem not to work. The footer can be removed.

remove_action('genesis_header', 'genesis_do_header'); remove_action('genesis_header', 'genesis_header_markup_open', 5); remove_action('genesis_header', 'genesis_header_markup_close', 15); remove_action( 'genesis_after_header', 'genesis_do_nav' );

Is this intended, or is there a workaround for this, or am i doing something wrong?

Thx Nick

edit: unregistering the primary menu did the trick

salcode commented 9 years ago

I see from your edit you've successfully removed the nav. To clarify, why you're seeing this behavior.

Default Genesis

By default both the nav and sub nav appear after the header. The default

add_action( 'genesis_after_header', 'genesis_do_nav' );
add_action( 'genesis_after_header', 'genesis_do_subnav' );

Bootstrap Genesis Modifications

Why

In my opinion the Bootstrap nav looks best at the top of the page and thus I've made this the default.

How

To accomplish this, I'm unhooking the nav and sub_nav from their default position (after the header) and hooking them before the header. (this all happens in lib/nav.php)

How to Remove the nav and sub_nav from Bootstrap Genesis

These lines will unhook the nav and subnav from their new position.

remove_action( 'genesis_before', 'genesis_do_nav' );
remove_action( 'genesis_before', 'genesis_do_subnav' );

As you pointed out, unregistering the menu will also work.

salcode commented 9 years ago

I'd like to start putting together a list of themes or sites that are using Bootstrap Genesis as a base. If you'd like to be included, please open a new issue and include your URL when your work goes live.

Thanks.

salcode commented 9 years ago

Added Wiki page Modifications from Default Genesis Hooks for a more accessible resource to address this question in the future

ghost commented 9 years ago

Hi Sal,

Thanks for your quick and clarifying response! I am currently still working on two websites, i will make an issue once they are available for public as suggested.

Cheers,

Nick

On 29 May 2015, at 12:40, Sal Ferrarello notifications@github.com wrote:

I'd like to start putting together a list of themes or sites that are using Bootstrap Genesis as a base. If you'd like to be included, please open a new issue and include your URL when your work goes live.

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/salcode/bootstrap-genesis/issues/86#issuecomment-106769840.