Currently all the CSS is loaded in css/style.min.css (this includes the Bootstrap CSS, the custom CSS, and any other CSS I include when building a specific them (e.g. the CSS for a slider I integrate into the theme)) and all the JavaScript is loaded in js/javascript.min.js (this includes the Bootstrap JavaScript, the custom JavaScript, and any other JavaScript I include when building a specific theme).
Should we stop concatenating CSS and JavaScript?
Advantages
this would allow us to a more standard handle like "bootstrap" for the Bootstrap CSS file and JavaScript file, which would help avoid conflicts when plugins try to load Bootstrap CSS and/or JavaScript
Disadvantages
increase the number of assets loaded on a page load
since we're using the Sass version of Bootstrap where we're modifying the Bootstrap variables, if a plugin enqueued CSS with the handle "bootstrap" first, the plugin Bootstrap CSS would load (and our theme Bootstrap CSS would not), which would result in default Bootstrap variable values rather than our modified file
Ultimately, I think concatenating the CSS and JavaScript is still the best path. If someone has further thoughts, I'm happy to revisit this topic and they should feel free to reopen this issue.
Currently all the CSS is loaded in
css/style.min.css
(this includes the Bootstrap CSS, the custom CSS, and any other CSS I include when building a specific them (e.g. the CSS for a slider I integrate into the theme)) and all the JavaScript is loaded injs/javascript.min.js
(this includes the Bootstrap JavaScript, the custom JavaScript, and any other JavaScript I include when building a specific theme).Should we stop concatenating CSS and JavaScript?
Advantages
Disadvantages