search

salcode / salcode-git

My Git configuration.
MIT License
3 stars 1 forks source link

Bring back bash_profile-mods.bash (and add zsh profile mods!) #10

Closed jrfoell closed 1 year ago

jrfoell commented 1 year ago

Would love to see those things added back to this (new) repo!

salcode commented 1 year ago

Thank you for your interest in this repo and the now archived ironcodestudio/ironcode-git-enhancements.

I think for me the shell aliases and functions are out of scope for this repo.

I also think these lines in my zsh configuration and the blog post Add git status to zsh prompt cover the same functionality for zsh (and as I'm no longer using bash, I don't want to take on the task of maintaining anything for bash specifically - sorry).

If there is any functionality that you were using that was in the bash_profile-mods.bash that isn't covered by these two resources, please let me know because I'd at least like to make a note of it (and maybe even add it in salcode/salcode-zsh).

I do realize this isn't as convenient as including a file like bash_profile-mods.bash (and I could imagine creating a separate repo to create a zsh file specifically for adding this Git stuff, but I don't foresee going down that path).

Thanks for bringing this idea up and making me put a little more thought into it.

salcode commented 1 year ago

After taking some time to think about this, I'm still of the same opinion I mentioned in my original comment.

I think for me the shell aliases and functions are out of scope for this repo.

I've tagged this as wontfix and I'm closing this issue.