search

saleae / logic2-automation

Logic2 Automation API
https://saleae.github.io/logic2-automation/
Apache License 2.0
19 stars 8 forks source link

Fix wheel build #34

Closed huffman closed 10 months ago

gbarkadiusz commented 10 months ago

We need this fix as fast as possible. @huffman Could you merge this pr and release 1.0.7 version.?

ofek commented 10 months ago

Change this https://github.com/saleae/logic2-automation/blob/b6468259c696a67168df5d5b3162afb8d3d07c6d/python/pyproject.toml#L43

to this:

[tool.hatch.build.targets.sdist.force-include]
huffman commented 10 months ago

@ofek Thank you!

@gbarkadiusz We'll have a release out shortly.

huffman commented 10 months ago

@gbarkadiusz 1.0.7 has been released - please let us know if you have any issue with the upgrade! https://pypi.org/project/logic2-automation/

@ofek Thanks again, I really appreciate the help! I'm sure you saved me an hour of debugging.

ofek commented 10 months ago

Happy to help! Also, cool project 🙂

ofek commented 10 months ago

FYI here's an explanation: https://github.com/pypa/hatch/issues/1130#issuecomment-1853296562

gbarkadiusz commented 10 months ago

@huffman Thank you for that quick investigation and fix. It works properly with my CI.