saleae / modbus-analyzer

Saleae Modbus Analyzer
MIT License
10 stars 3 forks source link

Needs mode for Master & Slave on single channel #2

Open timreyes opened 5 years ago

timreyes commented 5 years ago

Specifically, we should have a combined mode, called "Modbus/RTU - Master & Slave", which auto-detects the messages on a single data line as either Master or Slave. Modbus can have both Master & Slave messages on a single line.

The simplest solution is to try both decodings modes (master and slave) for each decoded frame (single blue decoded box) – the correct one for is the one with a valid Checksum.

david-vankampen commented 2 years ago

I believe this should be mostly addressed in #3 - I had issues using the failing checksum, so I just added a flag indicating whether it was processing a request or a response.

timreyes commented 1 year ago

The same issue might have been reported here too: https://discuss.saleae.com/t/modbus-analyzer/2024/2

ghost commented 11 months ago

@timreyes & @david-vankampen

Is there a fix for this yet? I am working with modbus and have no way to see the response from a device. Every message is considered a Server or Client. You need both call and response to properly understand what is happening on the bus.

Notice the "invalid checksum" in the attached image. The analysis on the Saleae's part is incorrect because the server is actually responding properly with a valid checksum. (CRC-16 assumed)

[RTU]>Tx > 15:01:56:189 - 01 03 00 80 00 02 C5 E3
[RTU]>Rx > 15:01:56:205 - 01 03 04 0D F2 07 BC 5A ED

image

david-vankampen commented 11 months ago

@sgal-powerbreezer it looks like #3 is still pending. I will bump that one.

ghost commented 11 months ago

thank you🙏