Closed mattias-persson closed 4 years ago
Hi @mattias-persson thanks for sharing I'll look at it now
I've tried it now, it's working :/ can you try the route to be '/' instead of empty string ''?
@saleem-hadad Thanks for looking! That's weird, maybe some issue occurred when I tried upgrading the package from v1.3. I'll try setting up a new Laravel-installation later and see if I can get it working.
@saleem-hadad Just tried again with a new installation of Laravel (5.8) and Larecipe (^2.1). Still have the same issue, when setting the docs.route
config key to ''
or '/'
I get the following error: Route [larecipe.index] not defined.
.
Seems to be caused by DocumentationRepository.php:30, $this->docsRoute = route('larecipe.index');
.
The exact steps:
composer require binarytorch/larecipe
php artisan larecipe:install
docs
part of config/larecipe.php
to look like this:
'docs' => [
'route' => '', // same result with or '/'
'path' => '/resources/docs',
'landing' => 'overview',
],
I think this got a fix in ^2.2 please confirm
Describe the bug I've used version 1.3 of the package for a long time on https://laravel-shopr.happypixels.se, where I've set the
docs.route
key in the config to''
, which removes the/docs
segment from the URL. Upgrading to version 2 of this package makes this setup crash with aRoute [larecipe.index] not defined.
error. If I add'/docs'
to the config value it works.To Reproduce
Expected behavior The docs should be presented without a '/docs'-prefix.
Desktop (please complete the following information):