search

saleem-mirza / serilog-sinks-sqlite

A Serilog sink that writes to SQLite
Apache License 2.0
56 stars 44 forks source link

Update Newtonsoft.Json nuget package. #20

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

https://github.com/saleem-mirza/serilog-sinks-sqlite/blob/dev/src/Serilog.Sinks.SQLite/Serilog.Sinks.SQLite.csproj -->

Package Link Installed Version Latest Version
Newtonsoft.Json https://www.nuget.org/packages/Newtonsoft.Json/ 12.0.1 12.0.2
SeppPenner commented 5 years ago

PR is there: https://github.com/saleem-mirza/serilog-sinks-sqlite/pull/21.

saleem-mirza commented 5 years ago

Please explain what issue this PR solves or what value it adds?

SeppPenner commented 5 years ago

I thought the benefits of keeping dependencies up to date are clear:

The release changes are here: https://github.com/JamesNK/Newtonsoft.Json/releases

SeppPenner commented 5 years ago

Ok, if you want to provide software that doesn't use the latest features and security patches^^ Not understandable for me though.

saleem-mirza commented 5 years ago

I don't just jump into what's new but stability. Thanks for your contribution though.

SeppPenner commented 5 years ago

Normally, updating shouldn't be a problem at all because that's what unit and integration tests are for. Just update, run the tests, if some fail, investigate and ask the dependency owner(s). If it doesn't, just keep it updated until some issue occurs (and revert the commit).

I don't just jump into what's new but stability. Thanks for your contribution though.

I disagree with that statement but it's your project.