salemdar / angular2-cookie

Implementation of Angular 1.x $cookies service to Angular 2
MIT License
109 stars 29 forks source link

Needs an upgrade #29

Open jrgleason opened 7 years ago

jrgleason commented 7 years ago

I am using "@angular/core": "^2.1.2", and I get.......

core.umd.js?e2a5:334Uncaught TypeError: Reflect.getMetadata is not a function(…)ParamDecorator @ core.umd.js?e2a5:334(anonymous function) @ base-cookie-options.js?d615:23decorate @ base-cookie-options.js?d615:16(anonymous function) @ base-cookie-options.js?d615:60(anonymous function) @ base-cookie-options.js?d615:67webpack_require @ bootstrap 12ee094…?36af**:19(anonymous function) @ services.js:8webpack_require @ bootstrap 12ee094…?36af**:19(anonymous function) @ core.js:11webpack_require @ bootstrap 12ee094…?36af**:19(anonymous function) @ deps.ts:8webpack_require__ @ bootstrap 12ee094…?36af:19(anonymous function) @ bootstrap 12ee094…?36af:39(anonymous function) @ bootstrap 12ee094…?36af**:39

The weird thing is it doesn't seem to cause any issues just seems to be annoying. I tried updating my polyfills to...

import "core-js/es6";
import "reflect-metadata";
import "core-js/es7/reflect";

But it didn't change anything

jrgleason commented 7 years ago

Sorry I also looked at other branches and didn't see anything from this arena so I didn't think it was getting worked on

waterfoul commented 7 years ago

This is actually caused by what I described in #31