search

salemdar / angular2-cookie

Implementation of Angular 1.x $cookies service to Angular 2
MIT License
109 stars 29 forks source link

encodeURIComponent #44

Open YnkDK opened 7 years ago

YnkDK commented 7 years ago

Although it might be "bad practice" not to, it should not be this projects responsibility to call encodeURIComponent when reading/writing cookies.

I am currently mitigating from Angular 1 to Angular 2, but this library breaks the comparability due to encodeURIComponent.

I have a cookie that contains | in the name, but using encodeURIComponent transforms this to %7C, and thus the subsequent calls to the backend contains the wrong cookie.

Can you either remove it or add the option to enable and disable this?

Necroskillz commented 7 years ago

angular 1 $cookies does this encoding as well.

It would be nice to have a raw parameter on put so we can set string as-is to a cookie. A use case for this it for example when you have a query string like value that you need to write that will be read on the server by ASP.NET application. This format is how ASP.NET serializes cookies.

key=value&key2=value2 get saved as key%3Dvalue%26key2%3Dvalue2 which ASP.NET can't parse.