search

salemhilal / warmd

WRCT: A Radio Music Database
Other
8 stars 1 forks source link

Upgrade Express to 4.0 #7

Closed salemhilal closed 10 years ago

salemhilal commented 10 years ago

At some point in the near future, some of the Express 3.0 nonsense needs to be refactored out. I may take a night and do this at some point, but if anyone ( @mcbaron ?) wants to take this on, be my guest. Shouldn't be too hard. I'm adding FIXME's to anything I come across that needs to be refactored out. Most of it is in config/express.js and config/routes.js

A review of the changes was covered pretty thoroughly here: http://scotch.io/bar-talk/expressjs-4-0-new-features-and-upgrading-from-3-0

salemhilal commented 10 years ago

I started a new branch for this (express–upgrade) and have removed all of the bundled middleware that's removed in express 4.0. About time they did that. Diff here: https://github.com/bichiliad/warmd/compare/799b8ea...511e455

salemhilal commented 10 years ago

Hmm, this is more or less done. I'd like to pretty up the routes.js file, but may happen later.

salemhilal commented 10 years ago

Ok, there's an awesome routes.js file I pushed some time last night. Closing this issue.