salemlf / hakubun

Cross-platform, third-party Japanese language learning app for use with WaniKani 🦀🐊
GNU General Public License v3.0
31 stars 7 forks source link

Disallow swiping left to retry if no answer has been submitted #377

Closed EricosEagle closed 4 months ago

EricosEagle commented 4 months ago

Hey! I noticed that you can attempt to retry a card before it has been submitted. I understand that the logic needs to be there in case someone uses the keyboard shortcuts, but I don't think we need to allow users to try to swipe to retry before submitting. Also, this is the first time I have worked on a Web / Mobile application, so feedback would be greatly appreciated!

salemlf commented 4 months ago

I appreciate the work you've put into this! I actually think I'd prefer to leave it as-is with the toast that displays a "Can't Retry" message displaying either that the input is empty or an answer hasn't been submitted. I think allowing users to "mess up" and displaying why that action isn't allowed can be helpful, otherwise the functionality can feel broken if the card doesn't move how they expected. I'm open to changing my mind though, let me know if you think that all makes sense!

salemlf commented 4 months ago

Closing this PR due to above comment, lemme know if you feel it should be reopened!