Replace tracer with OpenTracing compatible interface

salemove / freddy

Messaging api supporting request-response and acknowledgements.

MIT License

9 stars 0 forks source link

Replace tracer with OpenTracing compatible interface #55

Closed indrekj closed 7 years ago

indrekj commented 7 years ago

This allows using different tracing libraries. E.g.

OpenTracing.global_tracer = Logasm::Tracer.new(logger)
OpenTracing.global_tracer = SomeOtherTracerImplementation.new(...)

INF-982

ostap0207 commented 7 years ago

Should we pass tracer to Freddy instead of using global tracer. Just thinking of situations when you want to use tracing, but don't want to use it in Freddy or want to use different tracer. I think OpenTracing.global_tracing is useful for application tracing, not sure if it's the best to use inside a framework. I guess this can be changed later.

indrekj commented 7 years ago

@ostap0207 I think using OpenTracing.global_tracer is ok for now. Might change in future. I also added a comment about Freddy.trace to README. I'd like to keep the Freddy.trace interface the same atm (previous version already uses it) and I think it is ok (at least for now).