search

salemove / jaeger-client-ruby

OpenTracing Tracer implementation for Jaeger in Ruby
MIT License
62 stars 38 forks source link

Add mechanism to limit UDP message batch size #22

Closed zindorsky closed 5 years ago

zindorsky commented 5 years ago

Currently, if a batch can end up being larger than the UDP message size limit, causing its transmission to fail.

This MR would add a mechanism to check the size of batches and break them up, creating a "batch of batches" so to speak.

indrekj commented 5 years ago

You need to rebase against origin/master, there are some conflicting files. Also could use a test or two after the rebase.

indrekj commented 5 years ago

Oh, I didn't notice you addressed my comments. 👍

The build is currently failing though.

stelford commented 5 years ago

Any chance of getting this PR merged ? I am bumping into jaeger trace size on rails 5.x myself, so it would be deeply appreciated. For the record, the errors/failing checks currently is RuboCop jst kvetching about formatting.. hopefully not a show stopper ;)

luong-komorebi commented 5 years ago

Hi @zindorsky , are you still working on this ?

zindorsky commented 5 years ago

I haven't been working on it lately. Is there anything in particular you wanted done?

luong-komorebi commented 5 years ago

@zindorsky your implementation is interesting, it will be good seeing this merged, which is why I asked ;) If you are no longer into this, maybe your answer would enable someone else to continue your work

indrekj commented 5 years ago

Merged to master: 5620b3456b6436b7fa2d4431ab46ec656d3694f0