salemove / jaeger-client-ruby

OpenTracing Tracer implementation for Jaeger in Ruby
MIT License
62 stars 38 forks source link

logs reported twice #24

Closed c5c86a closed 5 years ago

c5c86a commented 5 years ago

The logs 'Span reported' are reported twice in rails. Is the following instantiation of LoggingReporter correct?

Jaeger::Client.build(
  host: jaeger_host,
  port: 5775,
  service_name: 'CompleteService',
  reporter: Jaeger::Reporters::LoggingReporter.new
)

If I do not use the reported argument, then I do not see logs with the words "Span reported".

indrekj commented 5 years ago

This should not be happening. I tried to reproduce but I was unable.

Can you show the output you're getting? Are you sure these are duplicate spans?

if they're not duplicate spans, then can you provide a script to reproduce it?

indrekj commented 5 years ago

Closing due to inactivity.