Follows_from references does not work

danielgatis commented 4 years ago

Hi!

I am trying to do an async span but it does not work. I am using the following snippet.

span_context = OpenTracing.extract(OpenTracing::FORMAT_TEXT_MAP, meta)

OpenTracing.start_active_span(
  "JOB PERFORM #{self.class.name}",
  references: [
    OpenTracing::Reference.follows_from(span_context)
  ],
  tags: {
    'component' => 'active-job',
    'span.kind' => 'consumer',
    'job_id' => self.job_id,
    'request_id' => request_id
  }
)

But in jaeger my span graph shows this span like a childOf instead of 'followsFrom'. See in the picture.

what am I doing wrong? Thanks.

indrekj commented 4 years ago

Is it different when using non-ruby libraries? From a quick glance the code you are using seems to be correct.

danielgatis commented 4 years ago

Is it different when using non-ruby libraries?

If you run the script/create_follows_from_trace you will see the same behavior.

danielgatis commented 4 years ago

I think this is a bug in jaeger related to this issue (https://github.com/jaegertracing/jaeger-ui/issues/358), so I will close this ticket.

salemove / jaeger-client-ruby

Follows_from references does not work #31