saleor / apps

A central space for Saleor Apps, integrations, and the App Store 🚀
https://apps.saleor.io
Other
114 stars 317 forks source link

Install apps with Vercel or via CLI is not working #69

Closed michalina-graczyk closed 1 year ago

michalina-graczyk commented 1 year ago
  1. Create a new env
  2. In apps install an app using 'Deploy to Vercel' image
  3. Do all required steps in Vercel
  4. Install app in dashboard Current result: "message":"Registration failed: could not save the auth data." "message":"APL_NOT_CONFIGURED. App is configured properly. Check APL docs for help." -> this one was for an app installed via CLI

image

lkostrowski commented 1 year ago

We decided to drop "deploy to vercel" since its unstable and replace it with Github Fork

https://github.com/saleor/apps/issues/98

simon-online commented 1 year ago

This is the exact issue that I am getting when I try to install the CMS app that I have successfully deployed on Vercel at https://saleor-apps-taupe.vercel.app/

Screen Shot 2023-05-25 at 2 25 39 pm

I tried this with dashboard v3.13.3 core v3.13.16 apps v1.6.0

What can I do to resolve this?

lkostrowski commented 1 year ago

@simon-online you need to set up your APL layer

https://docs.saleor.io/docs/3.x/developer/extending/apps/architecture/apl#what-is-apl

https://github.com/saleor/saleor-app-sdk/blob/main/docs/apl.md

On local development you can use FileAPL but in serverless environment you need to provide some layer of persistence. Can be redis/upstash/vercel KV etc

simon-online commented 1 year ago

Got it, thanks for that.

For anyone else interested I was able to deploy the cms app on Vercel by selecting saleor/apps as an external repository for a new Vercel project which automatically forked it on GitHub.

For successful deployment I did the following things:

This would also be the same way that you could deploy your own custom Saleor apps on Vercel.

lkostrowski commented 1 year ago

Great @simon-online , good to know that our native Upstash APL works with the same values as Vercel KV 🚀

simon-online commented 1 year ago

Although I seem to have hit another roadblock as detailed here: https://github.com/saleor/apps/issues/513

Not sure if this is the result of trying to use the Upstash APL with Vercel KV.