search

saleor / cli

Command-line interface allowing interaction with Saleor Cloud environments.
Other
70 stars 23 forks source link

Remove app deploy command #605

Closed lkostrowski closed 1 year ago

lkostrowski commented 1 year ago

I want to merge this PR because

We decided to drop 1st class support for 1-click deployment of the app to Vercel. This cost us a lot of maintenance and we don't really know any benefit of this feature.

AppStore is encouraging developers to fork the app on Github and deploy it on their own.

Related (issues, PRs, topics)

https://github.com/saleor/apps/issues/98 https://github.com/saleor/saleor-cli/issues/445

Steps to test the feature

  1. saleor app deploy should be no longer available

I have:

zaiste commented 1 year ago

@lkostrowski it's OK, but maybe we should first mark it as deprecated? a similar path you suggested for other CLI command removal?

lkostrowski commented 1 year ago

@zaiste technically we can, but telemetry shows that its not really used 🤔

@krzysztofwolski WDYT?

krzysztofwolski commented 1 year ago

If telemetry confirms that this feature was not really used, then we can drop it before new users will try to play with it. Of course, it should be marked as the next major version.

If there are some users of this feature, maybe it will be a good idea to display the deprecation message first when the command is used and schedule dropping it completely in 2-4 weeks.

lkostrowski commented 1 year ago

@zaiste @krzysztofwolski okay lets do it

https://github.com/saleor/saleor-cli/pull/607

@zaiste can you release it after its merged?