search

saleor / macaw-ui

MacawUI: an official UI design kit for Saleor
https://macaw-ui.vercel.app
100 stars 33 forks source link

Combobox virtualized list #452

Open lkostrowski opened 1 year ago

lkostrowski commented 1 year ago

What I'm trying to achieve

Display huge amount of results in Combobox

Currently huge dataset causes performance degradation

Tested on this dataset https://github.com/saleor/apps/blob/ca4306162f468ff00fa43fedf3ea486d9a027272/apps/products-feed/src/modules/category-mapping/google-product-categories.ts

Describe a proposed solution

Add Virtualized list with max items that are rendered

Acceptance Criteria

Screenshots or mockups

krzysztofzuraw commented 1 year ago

Guide on how to add react-virtual to downshift: https://www.downshift-js.com/use-combobox#virtualizing-items-with-react-virtual

lkostrowski commented 1 year ago

Comparison of virtualization libraries (owned by one of the libs)

https://github.com/inokawa/virtua#comparison

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 14 days with no activity.