search

saleor / requests-hardened

A library that overrides the default behaviors of the requests library, and adds new security features.
https://pypi.org/project/requests-hardened
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Add support for HTTP redirect in IP filtering feature #12

Open jakubkuc opened 11 months ago

jakubkuc commented 11 months ago

Passing allow_redirects flag to requests should be handled in requests-hardened. At the moment it is not possible and additional code is needed to be able to use redirects while using requests-hardened and that is not optimal for Saleor.

NyanKiyoshi commented 11 months ago

I removed the bug label as the IP filtering feature works as intended, it's a feature request.

But the following could be improved:

  1. Documentation should warn about the limitation
  2. The configuration should reject mixing ip_filter_enable=True and never_redirect=False as this is unsupported