Closed orzechdev closed 4 years ago
This pull request introduces 1 alert when merging e904459015e33a61678998a53e073d4b3c1dc261 into 35de1e0b131ea46f290a9225aede6468b8212641 - view on LGTM.com
new alerts:
@orzechdev I cannot add juices to the cart, not sure if thats issue with PR or staging api? https://refactor-cart-sidebar.storefront.saleor.rocks/product/carrot-juice/73/
There's an inconsistency which has to be addressed:
See names of products in the cart:
Same products, cart preview in checkout:
And order summary:
@orzechdev I cannot add juices to the cart, not sure if thats issue with PR or staging api? https://refactor-cart-sidebar.storefront.saleor.rocks/product/carrot-juice/73/
@krzysztofwolski It doesn't work also on https://master.staging.saleor.rocks/product/carrot-juice/73/. I guess it's an issue with staging API, which doesn't return any attribute values for variants.
Task linked: SALEOR-636 CartSidebar component
passed to QA
I want to merge this change because... it moves cart sidebar to
@next
directory with implemented new style and fixed cart row styles.Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/