saleor / saleor-storefront

A GraphQL-powered, NextJs-based, PWA storefront for Saleor. IMPORTANT: This project is [DEPRECATED] in favor of saleor/react-storefront soon to become our default demo and storefront starter pack.
https://demo.saleor.io/
BSD 3-Clause "New" or "Revised" License
769 stars 672 forks source link

New cart sidebar #907

Closed orzechdev closed 4 years ago

orzechdev commented 4 years ago

I want to merge this change because... it moves cart sidebar to @next directory with implemented new style and fixed cart row styles.

Zrzut ekranu 2020-09-29 o 19 30 22 Zrzut ekranu 2020-09-29 o 19 38 22

Screenshots

Pull Request Checklist

  1. [x] All visible strings are translated with proper context.
  2. [x] All data-formatting is locale-aware (dates, numbers, and so on).
  3. [ ] The changes are tested.
  4. [x] The code is documented (docstrings, project documentation).
  5. [x] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging e904459015e33a61678998a53e073d4b3c1dc261 into 35de1e0b131ea46f290a9225aede6468b8212641 - view on LGTM.com

new alerts:

krzysztofwolski commented 4 years ago

@orzechdev I cannot add juices to the cart, not sure if thats issue with PR or staging api? https://refactor-cart-sidebar.storefront.saleor.rocks/product/carrot-juice/73/

krzysztofwolski commented 4 years ago

There's an inconsistency which has to be addressed:

See names of products in the cart: image

Same products, cart preview in checkout: image

And order summary: image

orzechdev commented 4 years ago

@orzechdev I cannot add juices to the cart, not sure if thats issue with PR or staging api? https://refactor-cart-sidebar.storefront.saleor.rocks/product/carrot-juice/73/

@krzysztofwolski It doesn't work also on https://master.staging.saleor.rocks/product/carrot-juice/73/. I guess it's an issue with staging API, which doesn't return any attribute values for variants.

Zrzut ekranu 2020-09-30 o 18 06 29

patrys commented 4 years ago

Task linked: SALEOR-636 CartSidebar component

orzechdev commented 4 years ago

passed to QA