Improve readability in the code by adding id-length rule

What I'm trying to achieve

Right now it is almost impossible to know what some functions do due to shortcutting identifiers. Especially shortcutting definitions like the code example below:

export const maybe = <T>(exp: () => T, d?: T) => {
  try {
    const result = exp();
    return result === undefined ? d : result;
  } catch {
    return d;
  }
};

This is terrible to read and very hard for new developers to understand what this function does. The utility function is not descriptive nor do the parameters describe what they stand for.

Describe a proposed solution

I would like to add a rule to the eslint called id-length https://eslint.org/docs/rules/id-length

The end result of this function would be

export const tryExpression = <T>(expression: () => T, data?: T) => {
  try {
    const result = expression();
    return result === undefined ? data : result;
  } catch {
    return data;
  }
};

The function is descriptive and also the parameters are a lot more readable.

Alternative

An alternative would be to add JSDoc to the codebase that will help describe what functions and classes do. For now it seems redundant due to the amount of typescript already covering most of what JSDoc does.

saleor / saleor-storefront