search

saleor / saleor-storefront

A GraphQL-powered, NextJs-based, PWA storefront for Saleor. IMPORTANT: This project is [DEPRECATED] in favor of saleor/react-storefront soon to become our default demo and storefront starter pack.
https://demo.saleor.io/
BSD 3-Clause "New" or "Revised" License
769 stars 672 forks source link

fix bug with LoadMore button for collection page; #924

Closed yevheniidehtiar closed 4 years ago

yevheniidehtiar commented 4 years ago

I want to merge this change because i found bug, and button LoadMore was not worked on Collection Pages.

Screenshots

Pull Request Checklist

  1. [x] All visible strings are translated with proper context.
  2. [x] All data-formatting is locale-aware (dates, numbers, and so on).
  3. [x] The changes are tested.
  4. [x] The code is documented (docstrings, project documentation).
  5. [ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

yevheniidehtiar commented 4 years ago

Seems previous approach with envs is deprecated now. See log details 1

Gitlab changelog That's why QA / cypress-run fails

dominik-zeglen commented 4 years ago

It's expected to fail if you're not a member of the organisation, as a security precaution.