Add channel slug to URLs

saleor / storefront

Saleor Storefront built with React 18, Next.js 14, App Router, TypeScript, GraphQL, and Tailwind CSS.

https://storefront.saleor.io

BSD 3-Clause "New" or "Revised" License

1.01k stars 585 forks source link

Add channel slug to URLs #1046

Closed typeofweb closed 9 months ago

typeofweb commented 9 months ago

Fixes #1029

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
storefront	✅ Ready (Inspect)	Visit Preview	Nov 27, 2023 2:21pm

zaiste commented 9 months ago

@mmiszy default-channel doesn't have to be visible in the pathname.

grzegorzpokorski commented 9 months ago

@mmiszy CheckoutLink on the /cart page also lacks a channel in the href. Perhaps a good solution would be a middleware that adds a default channel to the links in situations where it doesn't have a channel in the pathname?

typeofweb commented 9 months ago

@grzegorzpokorski CheckoutLink doesn't need a channel.