search

saleor / storefront

Saleor Storefront built with React 18, Next.js 14, App Router, TypeScript, GraphQL, and Tailwind CSS.
https://storefront.saleor.io
BSD 3-Clause "New" or "Revised" License
1.01k stars 585 forks source link

refactor: refactor login form #1049

Open grzegorzpokorski opened 9 months ago

grzegorzpokorski commented 9 months ago

Few accessibility related touches.

vercel[bot] commented 9 months ago

@grzegorzpokorski is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

zaiste commented 9 months ago

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

grzegorzpokorski commented 9 months ago

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

Thank you for the clarification! Initially, this component was located next to the cart page in the src/app/[channel]/(main)/login directory. Perhaps I should move this component back to that directory? What do you think? Should I place components next to the pages files? Answers would make that topic more clear for me 🙂

grzegorzpokorski commented 9 months ago

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

I apologize for any confusion. I will keep that in mind.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
storefront ✅ Ready (Inspect) Visit Preview Jul 23, 2024 6:37am