saleor / storefront

Saleor Storefront built with React 18, Next.js 14, App Router, TypeScript, GraphQL, and Tailwind CSS.
https://storefront.saleor.io
BSD 3-Clause "New" or "Revised" License
1k stars 578 forks source link

Formik future #723

Open bmigirl opened 1 year ago

bmigirl commented 1 year ago

Currently, we're using Formik in checkout-storefront. Considering all alternatives, we've decided It's our best option. Formik gives us almost all we need. However, it could work better since some features are missing and there are some bugs that have been around for years (and no fixes in sight). Moreover, future maintenance of the lib by the original author is in question. We should wait and see whether the community decides to take ownership of Formik. If that won't happen, we could potentially consider forking it. We could then also use in storefront and other packages / apps if needed.

Currently most of the below are handled in checkout-sf on our side.

### Bugs to fix
- [ ] Autofill doesn't trigger changes properly, the values remain outdated until some other action / method from form return is fired
- [ ] ValidateField doesn't work in some cases (used for email validation) https://github.com/jaredpalmer/formik/issues/1755
### Improvements
- [ ] Typing for form return, right now we manually type setFieldValue to take in keyof FormData and not any string
- [ ] Optional onSubmit (it's been a long requested feature but never implemented) https://github.com/jaredpalmer/formik/issues/2675
- [ ] Add types for ChangeHandler, BlurHandler
- [ ] Add passing dirty prop to onSubmit so we could abort if dirty
github-actions[bot] commented 1 year ago

This issue had no activity for more than 90 days. Labelling as stale.

It'll be automatically closed withing 30 days of no activity.

github-actions[bot] commented 1 year ago

This issue had no activity for more than 90 days. Labelling as stale.

It'll be automatically closed withing 30 days of no activity.