salesagility / SuiteCRM-Core

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
176 stars 123 forks source link

GraphQL requests triggering too frequently #328

Open yunusyerli1 opened 1 year ago

yunusyerli1 commented 1 year ago

Issue

The problem is that "Record Logic" is being currently triggered too many times (16 times or more) when you switch from one tab to another. This shouldn't happen.

Expected Behavior

Whenever changing the tap, GraphQL doent get triggered too many times.

Actual Behavior

Whenever changing the tap, only one GraphQL call needs to be requested.

Possible Fix

Holding record-view previous values to array and checking this array shoulf trigger GrapgQL Call if there is difference.

Steps to Reproduce

  1. Set up an address picker component as extension.
  2. Change tabs.
  3. Check network tab in browser

Context

Having too many GraphQL calls repetitively can cause performance issues.

Your Environment

johnM2401 commented 1 year ago

Hey Yunus!

I've added some record/display logic on a Module, (granted not as intricate as an address picker extension), and i'm not able to replicate.

Could you perhaps give some more in-depth details, or an alternate way to replicate this issue on a vanilla SuiteCRM8 environment?

I believe an Address Picker is not core functionality, so it sounds like this is part of a customized instance. Do you see this issue in a vanilla install of SuiteCRM8?

Thanks!