search

salesagility / SuiteCRM-Outlook-Plugin

GNU Lesser General Public License v3.0
64 stars 69 forks source link

Meeting duration turns to 0 #104

Open samus-aran opened 5 years ago

samus-aran commented 5 years ago

Issue

Intermittently the Outlook plugin will touch a Outlook Meeting object and set the duration_hours and/or duration_mins to 0. This appears to only happen when synchronising both from Outlook & SuiteCRM

Expected Behavior

Meetings should only be updated triggered by a change

Actual Behavior

Some meetings are updated without user interaction with duration_hours or/and duration_mins set to 0

Possible Fix

Areas of interest are: Exception: https://github.com/salesagility/SuiteCRM-Outlook-Plugin/blob/000d937f91646f4dfec04e1c7e92c65f1306e2d9/SuiteCRMAddIn/Exceptions/DurationSetToZeroException.cs#L13 When Zero is detected: https://github.com/salesagility/SuiteCRM-Outlook-Plugin/blob/000d937f91646f4dfec04e1c7e92c65f1306e2d9/SuiteCRMAddIn/BusinessLogic/AppointmentSyncState.cs#L123

Changing the Meeting Duration functionality: https://github.com/salesagility/SuiteCRM-Outlook-Plugin/blob/7dbfe0b7243f147a26bbc814bfcd0e1a84eab706/SuiteCRMAddIn/BusinessLogic/MeetingsSynchroniser.cs#L76

Steps to Reproduce

  1. Set Synchronisation "Meetings" to "Both"
  2. Create a new Meeting with time of the start/end more than 0
  3. Watch it being synchronised up to SuiteCRM
  4. Leave it and potentially see that the Meeting on Outlook is 0

Context

Logs

Your Environment