search

salesagility / SuiteCRM-Outlook-Plugin

GNU Lesser General Public License v3.0
64 stars 69 forks source link

Feature wixsetup installer #87

Closed JanSiero closed 5 years ago

JanSiero commented 5 years ago

This pull requests implements an installer based on the Wix toolset.

Wix is freely available and open source, flexible and more modern than the current Installshield installer. Moreover, Installshield limited edition is not supported with visual studio community.

The installer resembles the Installshield installer, except for the missing "splash screen", for which I haven't had time. Everything can be configured using the single xml file "Product.wxs". In this file, the lines are documented with links to further information.

To build the installer, the wix toolset needs to be installed, which can be downloaded here: http://wixtoolset.org/releases/

The Wix extension for Visual Studio is installed automatically when loading the project in MS Visual Studio 2017, but can also be installed manually from the same link above.

Used documentation:

simon-brooke commented 5 years ago

Thanks, I'll have a look at this over the next week.

On Tue, 20 Nov 2018 at 22:00, Jan Siero notifications@github.com wrote:

This pull requests implements an installer based on the Wix toolset

Wix is freely available, flexible and more modern than the current installshield installer.

The installer resembles the installshield installer, except for the missing "splash screen", for which I haven't had time. Everything can be configured using the single xml file "Product.wxs". In this file there are links to further information.

To build the installer, the wix toolset needs to be installed: http://wixtoolset.org/releases/

The plugin for Studio is installed automatically when loading the project in MS Visual Studio 2017, but can also be installed manually.

Used documentation:

You can view, comment on, or merge this pull request online at:

https://github.com/salesagility/SuiteCRM-Outlook-Plugin/pull/87 Commit Summary

  • Implemented installer based on WiX Toolset v3
  • Add aditional resources to WixSetup Project file, unify line breaks
  • Add support for X64 Outlook
  • Update version number

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/salesagility/SuiteCRM-Outlook-Plugin/pull/87, or mute the thread https://github.com/notifications/unsubscribe-auth/AFPvW0Skl5uYMUQPvXdELkKV_fgKw5wxks5uxHuOgaJpZM4YsAOl .

-- Simon Brooke :: http://www.journeyman.cc/~simon/

    ;; Stultus in monte
simon-brooke commented 5 years ago

This is merged and we're evaluating - there's no commitment yet that we'll release it into master, but unless there are any major problems with it it's likely.

JanSiero commented 5 years ago

Hi Simon,

Thanks! I hope it simplifies work in the installer. I'll see if I can also add the splash screen ("Who we are") and add more languages to the plugin itself.

In case you have any questions concerning WiX toolset, let me know.

Best regards, Jan

simon-brooke commented 5 years ago

OK, initial impression: it didn't pick up the client libraries, but now I've fixed that and it's building both 'DEBUG' and 'RELEASE' builds cleanly. The installer works. I'm checking over for any issues, and I'll look to integrate my auto-version-number-incrementation code into it, but on the whole this looks good.

I've passed the generated installer onto the SalesAgility QA team for their evaluation.

On Thu, 6 Dec 2018 at 13:55, Jan Siero notifications@github.com wrote:

Hi Simon,

Thanks! I hope it simplifies work in the installer. I'll see if I can also add the splash screen ("Who we are") and add more languages to the plugin itself.

In case you have any questions concerning WiX toolset, let me know.

Best regards, Jan

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/salesagility/SuiteCRM-Outlook-Plugin/pull/87#issuecomment-444878326, or mute the thread https://github.com/notifications/unsubscribe-auth/AFPvWzi8n1BFgCpu4IKpG4IZ94TWJnPNks5u2SHmgaJpZM4YsAOl .

-- Simon Brooke :: http://www.journeyman.cc/~simon/

    ;; Stultus in monte