CSS changes + languages

salesagility / SuiteCRM-Portal-Joomla

Joomla Plugin for the SuiteCRM Portal

GNU General Public License v2.0

22 stars 21 forks source link

CSS changes + languages #11

Closed boombata closed 2 years ago

boombata commented 7 years ago

Hi, Changed a bit the CSS and pages added language files for french and italian.

Regards, BM.

horus68 commented 7 years ago

@boombata can you clean up your PR to remove the translation files from it? To install translations you just need to install the zip pack for your language in the Joomla admin. Language packs available here https://crowdin.com/project/suitecrm-advanced-openportal

horus68 commented 7 years ago

@boombata also consider to:

Language values in Language files must be enclosed in quotes, not single quotes. See: https://docs.joomla.org/Specification_of_language_files COM_KEY_CONSTANT="My value"
The language file sys.ini should have just the strings for specific admin actions not for administration translation (so usually its a file with fewer keys)

sys.ini file is used a. during the extension's installation, to allow localising the post-installation messages, b. to build the administrator Components menu, c. to localise component parameters and menu parameters d. and in the Extension Manager->Manage. See: https://docs.joomla.org/Specification_of_language_files

boombata commented 7 years ago

Thanks for all your comments, I will clean this PR as soon as possible.

horus68 commented 7 years ago

@boombata the proper branch for PR to actual version is the Hotfix branch, not the master. Maybe you should also consider to split the PR in two: One for the CSS changes and the other only for languages fixes and new strings. This would be better to avoid collisions with next versions.

I also submitted a PR to Hotfix branch to allow admin translation to the actual version (no collisions with your PR). After Salesagility merge those PR on languages to the actual version (AOP 2.x) then we should take a look the new 3.x branch