Fix in SugarCasesConnection.php getCases() call of fromSugarCases()

salesagility / SuiteCRM-Portal-Joomla

Joomla Plugin for the SuiteCRM Portal

GNU General Public License v2.0

22 stars 21 forks source link

Fix in SugarCasesConnection.php getCases() call of fromSugarCases() #31

Closed muzy closed 4 years ago

muzy commented 6 years ago

SugarCase() expects two parameters but only one is given. It appears that supplying an empty array helps and makes AOP usable again. Still this needs to be revised to correctly add the required relationships.

pgorod commented 5 years ago

I believe #32 is the correct fix for this, so I suggest closing this one.

Both work, but that one is more correct technically. It mimics the default parameters of the method in the parent class. It's ok to pass an empty array because the method that will end up executing is ready for that.

Thanks