Fix# 10321 Creation of Project with Template Causes 500 Error

pstevens71 commented 8 months ago

Description

I believe this line was added in the wrong place as part of: https://github.com/salesagility/SuiteCRM/commit/9aff7071bb86df7e06e2cf56aa3060fc00e3978a

It appears in the final code in line 613 not 330.

This causes the array to re-initialize and then subsequently causing a 500 error because the date in the second iteration is blank in the array and cannot be converted to a date and returns boolean false.

Motivation and Context

This is necessary to fix because no projects can be created with templates with this bug.

How To Test This

Try to create a project with a template with more than one task and try to save it. It will result in 500 error.

Make the fix and it will work as expected.

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

[x ] My code follows the code style of this project found here.
[ ] My change requires a change to the documentation.
[x ] I have read the How to Contribute guidelines.

SuiteBot commented 8 months ago

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/project-templates-cause-500-error-when-creating-new-project/91589/11

serhiisamko091184 commented 8 months ago

Hello @pstevens71,

Thanks for your PR,

I've managed to replicate an issue and get 500 error creating a project with a project template where two tasks are nested and after applying the current fix it was possible to get a proper result.

At the same time having tested the same behavior with another template with 4 tasks, I had to wait for about 2-3 minutes and I got the same error:

Are you experiencing similar issues depending on a number of tasks in the project template?

Thanks in advance!

Regards, Serhii

pstevens71 commented 8 months ago

Thanks @serhiisamko091184 for testing. I've tested with projects with many tasks and they worked for me. Hmm it's interesting 4 tasks creates a problem. I'll test on my end as well with exactly 4 tasks and see what happens. Did all your tasks have start dates and end dates? The issue get's created when the date is blank and it tries to convert a null value to a date. The fix above removes the cause that resets the date back to null inside the loop, so more than one task causes an error. There may be other problems here. Probably an if statement would be helpful if NULL, do not process the date conversion and you won't get the 500 error. But really we should figure out the root cause if it's other than the fix I've proposed.

serhiisamko091184 commented 8 months ago

Thank you for your quick reply @pstevens71,

Yes, everything is OK with the dates. I moved to a fresh instance with testing and I have proper results applying this fix (projects are created without error and despite the number of tasks).

Thanks one more time!

Regards, Serhii

pstevens71 commented 8 months ago

I just did another test with 4 project tasks and it worked fine. @serhiisamko091184 did you enter anything different other than the duration in the tasks? Just trying to figure out what's going on. Also, what 500 error are you getting? Can you check the logs. The only thing that stands out to me is your date format is different. That might be a clue.

serhiisamko091184 commented 8 months ago

Hello @pstevens71, thanks for getting back to me and the set of questions,

did you enter anything different other than the duration in the tasks? - no, nothing what 500 error are you getting? - the same as you shared in the issue via community forum The only thing that stands out to me is your date format is different - thanks for the suggestion, I had a chance to work this issue out more carefully and your fix works fine for me at the moment. Additional details/questions might appear on further stages of code review or testing.

Thanks a lot for your communication!

Regards, Serhii

salesagility / SuiteCRM