Fix #10170 - Call/Meeting Reminders - Can lock out user from any action besides F5

oskhel commented 8 months ago

Fix for issue with mask overlay not disappearing in create-view

Description

Fix for issue 10170. The problem is caused by the code that displays the confirmation alert for removing "remindee" being unable to identify the correct Reminder-object to show the confirmation for when there are several new reminders added at once. This makes it open a Confirm-dialog for each and every new reminder being added, causing issues when the cancel-button is clicked.

My fix involves using an iterative client-side id that is independent of missing suitecrm-id's when they are missing for new records.

Motivation and Context

This fix solves a GUI issue that improves the user experience.

How To Test This

Call / Meeting -> Open Create Call or Meeting.
Add two reminders.
Remove a user from one of the reminders and get prompt message to which you press Cancel.

Prior to this fix the background overlay would stay in place, blocking all elements. After applying this fix the overlay is cleared when clicking cancel.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

[X] My code follows the code style of this project found here.
[ ] My change requires a change to the documentation.
[X] I have read the How to Contribute guidelines.

SuiteBot commented 8 months ago

All committers have signed the CLA.

chris001 commented 8 months ago

@oskhel Please add the email address used for this commit to your github account by going here, then recheck you signed the CLA.

oskhel commented 8 months ago

Hi @chris001 It is signed. However, I seem to have missed having an email in my first commit (amended in a second commit) which might be the cause? Should I remove this pull request and create a new one where the email is present in all commits?

serhiisamko091184 commented 8 months ago

Hi @oskhel,

thanks for your contribution!

Regards, Serhii

serhiisamko091184 commented 3 months ago

Hello @oskhel,

thanks for contributing to the SuiteCRM project,

would you be so kind to check on the review comments.

Thanks in advance!

Regards, Serhii

salesagility / SuiteCRM