Fix #10353 - Fatal error in AOR Reports dashlet

salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world

https://www.suitecrm.com

GNU Affero General Public License v3.0

4.29k stars 2.04k forks source link

Closed fluffyballs closed 2 months ago

fluffyballs commented 5 months ago

Fix #10353

Fixes fatal error.

Repeat procedure defined in issue.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

SuiteBot commented 5 months ago

All committers have signed the CLA.

serhiisamko091184 commented 5 months ago

Hey @fluffyballs,

thanks for your contribution,

I'd like to draw your attention to the commit:

would you be so kind to update your commit message to the following format below:

More useful information on how to contribute is available here:
https://docs.suitecrm.com/community/contributing-code/bugs/

Many thanks in advance!

Regards, Serhii

chris001 commented 5 months ago

Yes, @fluffyballs in your commit message, you only need to add the missing # next to the 10353, making it #10353

fluffyballs commented 5 months ago

Sorry, typo when writing the message. It should be updated now.

serhiisamko091184 commented 5 months ago

Hi @fluffyballs,

thanks a lot for the quick response and update!

Regards, Serhii

jack7anderson7 commented 2 months ago

Hi @fluffyballs,

Thank you for your contribution and the time you took to create the PR

We have ultimately chosen to go with another PR that resolves this issue: #10411 , so we will close this PR.

However we are still grateful for your time and contribution.

Thank you again Jack