The changes in the said commit introduce the variable $additionalStep in modules/Upgradewizard/index.php
This variable is initalized in line 509, but already used before in line 297 without initialization. This causes the commit.php to be executed twice.
Motivation and Context
As commit.php is secured to not run its logic twice, this bug does not have any implications for now, however future changes might cause an issue here.
How To Test This
install SuiteCRM 7.14.2
upgrade to SuiteCRM 7.14.3
Expected result
commit.php is only called once
Observed behaviour
the file upgradewizard.log shows two entries of the line "[At commit.php]"
This can also be verified by debugger.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Final checklist
[x] My code follows the code style of this project found here.
[ ] My change requires a change to the documentation.
This PR fixes an issue that "commit" is called twice when runing the upgradewizard caused by changes in: https://github.com/salesagility/SuiteCRM/commit/890e5997a02666b925623cd53b99a81609fa481d#diff-7c5c0ada659df5cc72d508d4b597f1882ede2ee19a4a243010a84b9a3a8b4213
Description
The changes in the said commit introduce the variable $additionalStep in modules/Upgradewizard/index.php This variable is initalized in line 509, but already used before in line 297 without initialization. This causes the commit.php to be executed twice.
Motivation and Context
As commit.php is secured to not run its logic twice, this bug does not have any implications for now, however future changes might cause an issue here.
How To Test This
Expected result commit.php is only called once
Observed behaviour the file
upgradewizard.log
shows two entries of the line "[At commit.php]" This can also be verified by debugger.Types of changes
Final checklist