salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.27k stars 2.03k forks source link

Fix #10377 - Fix issues with global search not displaying values correctly #10378

Open JackBuchanan opened 3 months ago

JackBuchanan commented 3 months ago

Update how enums fields, currency fields and module names are displayed in global search

Description

Use enum label instead of key Use module label instead of module name Display currency fields as currency and not numbers

Motivation and Context

Fixes display issues when using global search

How To Test This

Use global search on module that has a currency and enum field e.g. opportunities

Types of changes

Final checklist

serhiisamko091184 commented 3 months ago

Hey @JackBuchanan!

Thanks for your contribution!

Regards, Serhii

johnM2401 commented 1 week ago

Hey @JackBuchanan ! I've had a look at this PR locally and while the displaying/formatting of these fields have been improved, I think there are some items that could be further improved.

See screenshots to show this.

Screenshots 1 and 2 show before/after fix, for various field types. Screenshot 2024-06-26 131342

Screenshot 2024-06-26 131358

Screenshots 3 and 4 show the difference with Listview/Search view for the "Amount" and "Opportunity Amount" fields Screenshot 2024-06-26 132407

Screenshot 2024-06-26 132419

What are your thoughts?

Thanks!