Correctly find the id of related objects in search results

When a search results contain records which have related links in them; the link to the related record does not contain the correct related record id. This causes the link to go to a page with an error message of Error retrieving record. This record may be deleted or you may not be authorized to view it.

NOTE This bug is documented in Pull Request #9823 which seems to only have not been merged due to the formatting of the Pull Request itself.

This issue affects all previous versions of 7.12.x - 7.14.x

Description

Spin up a new SuiteCrm installation
Go to Administration > Module Builder
Create a new Package and Module
Add a One-to-Many relation of your new module to Accounts
Deploy the package
Go to Administration > Search Settings and add your new module
Go to the new module
Create a new record with a related Account
Search for your new record in the global search
Click the record link and the account name
on master, the record link will go to the record and account name link will 404 when going to the Account module with the record id

search-result-bad-link

Motivation and Context

When searching for a record which has a related record, a user may want to click on the related record. Currently, the user will be shown a link to the related record; however, it will 404 when clicking on it.

How To Test This

Spin up a new SuiteCrm installation
Go to Administration > Module Builder
Create a new Package and Module
Add a One-to-Many relation of your new module to Accounts
Deploy the package
Go to Administration > Search Settings and add your new module
Go to the new module
Create a new record with a related Account
Search for your new record in the global search
Click the record link and the account name
on master, the record link will go to the record and account name link will 404 when going to the Account module with the record id
after this fix, the record link will continue to go to the record and the account name link will go to the Account module using the Account id

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

[X] My code follows the code style of this project found here.
[ ] My change requires a change to the documentation.
[X] I have read the How to Contribute guidelines.

salesagility / SuiteCRM