bugfix #10418 Global Search Labels fixed

[lionfaris]

When a user performs global search in the page that opens search button has empty label

After the fix

Description

Motivation and Context

How To Test This

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[serhiisamko091184]

Hello @lionfaris,

thanks for your PR,

could you please update the commit message to the following format: Fix Issue number - Commit message? For example:

For more information, visit our documentation: https://docs.suitecrm.com/community/contributing-code/bugs/

Thanks a lot in advance!

Regards, Serhii

[lionfaris]

@serhiisamko091184 Amended the commit message

[serhiisamko091184]

Hello @lionfaris,

thanks for your quick reply and changes,

would you be so kind to spend a little bit of your time and change the commit message to conform with the documentation?

Like here:

The hyphen is missing:

Thanks in advance!

Regards, Serhii

[lionfaris]

@serhiisamko091184 updated

[serhiisamko091184]

Many thanks, @lionfaris!

[clemente-raposo]

Hi @lionfaris,

Thank you for your PR.

When re-reviewing I noticed the following:

In tpls we commonly use {sugar_translate label="LBL_VIEWINLINE"} instead of directly using the translate() function. Using sugar_translate on tpls is preferable.

Anyway, there is another PR that is fixing the same issue:

• https://github.com/salesagility/SuiteCRM/pull/10186

Had you though of the solution on the PR above? I'm asking just to understand if there is any drawbacks on it that you might have found.