salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.26k stars 2.03k forks source link

DataTable TableTools .swf scripts in jjwg_Maps module are not working #10420

Open gp-lnuff opened 1 month ago

gp-lnuff commented 1 month ago

Issue

After making a Map record and opening it from the List View, the map with markers is shown above, while a table with the related records is shown below it. On the top right of the table are several buttons: Copy, CSV, XLS, PDF, and Print. These buttons are not working as expected.

Expected Behavior

Pressing the Copy button should copy the contents of the datatable to the clipboard, pressing the CSV button should prompt the user to save a .csv file or start a download for a .csv file, pressing the PDF button should prompt the user to save a .pdf file or start a download for a .pdf file, and pressing the XLS button should prompt the user to save a .xls file or start a download for a .xls file

Actual Behavior

The mentioned buttons are completely unresponsive. The Print button seems to be working as intended though

Possible Fix

It seems these buttons rely on .swf scripts and it's possible that they have been deprecated since the dismissal of Flash. A possible fix could be to look into a newer version of DataTable Table Tools (which seems to be the source of these buttons) and how to integrate it into SuiteCRM.

Steps to Reproduce

  1. Create a Map Record with at least 1 marker (to do this I suggest setting a very large range for your map, such as 10000km)
  2. Open the map record from the listview
  3. Click on the CSV, XLS, PDF and Copy buttons on the top right of the datatable

Context

After setting up Google Maps we realized during testing that these buttons were unresponsive. It's not a particularly critical deal and we've opted to hide these buttons by removing their definition in https://github.com/salesagility/SuiteCRM/blob/hotfix/modules/jjwg_Maps/views/view.map_markers.php#L694-L728

This issue is being opened at the request of @pgorod

Your Environment

SuiteBot commented 1 month ago

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/maps-module-hide-export-buttons/92638/6