salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.26k stars 2.03k forks source link

Incorrect lengths in emails_text vardefs #10443

Open ojs87 opened 3 weeks ago

ojs87 commented 3 weeks ago

Issue

The fromaddr and reply_to_addr fields in emails_text vardefs are set to 250 when they should be 255. This has caused an issue where repair and rebuild keeps trying to recreate the index on the fromaddr field in some situations

Possible Fix

update emails_beansMetaData.php to fix length on these 2 fields

Steps to Reproduce the Issue

Example of repair and rebuild message.

/* Table : emails_text */
/*COLUMNS*/
/* INDEXES */
/*INDEX MISMATCH WITH DATABASE - emails_textfromaddr -  ROW <name> emails_textfromaddr <type> index <fields>[0] => 'from_addr (250)'  */
/* VARDEF - emails_textfromaddr -  ROW<name> emails_textfromaddr <type> index <fields>[0] => 'from_addr'  */
ALTER TABLE emails_text   DROP INDEX emails_textfromaddr,  ADD INDEX emails_textfromaddr (from_addr);

Context

This looks to have been unintentionally changed in a previous MR: https://github.com/salesagility/SuiteCRM/pull/7798

Version

7.14.3

What browser are you currently using?

Chrome

Browser Version

Firefox v126.0

Environment Information

Mariadb 10.5.6, PHP74

Operating System and Version

Ubuntu 22.04.4 LTS