salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.26k stars 2.03k forks source link

Fix #10446 - Resolve issue preventing link creation in Security Groups sub-panels #10447

Open gaspare-joubert opened 2 weeks ago

gaspare-joubert commented 2 weeks ago

Description

This commit addresses an issue where related custom module items couldn't be selected via sub-panels. The problem occurred when the bean with the relationship link property was empty and not an instance of Link2.

The root cause was identified within the Link2 class's add() function, specifically when the getSide() method returns 'RHS'. This situation arose when either the 'RHS' or 'LHS' was set to 'SecurityGroup' in the M2MRelationship add() function.

Motivation and Context

This will fix a bug where you are unable to make selections using Security Groups sub-panels.

How To Test This

1.Open the Security groups module ui 2.Use the 'Create' button's 'Select' option on any custom module 3.In the pop-up window select a single or multiple options using the checkbox 4.Click 'Select'

Types of changes

Final checklist

serhiisamko091184 commented 2 weeks ago

Hello @gaspare-joubert,

thanks for your contribution!

Regards, Serhii