salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.46k stars 2.08k forks source link

Data fields: Tab order and Z cross in detail or edit views #5310

Open horus68 opened 6 years ago

horus68 commented 6 years ago

Issue

There must be an order for data fields in detail and edit views so it feels comfortable to read the fields content by "regular" desktop browser users with 2 columns layout but also for those using tabs to move into fields (as in screen readers used by blind and vision impaired people). Fields are usually

Both cases require to be tested in single column layouts (as in mobile).

In SuiteCRM there isn't a proper fields layout as sometimes fields are apart each other even if they look grouped. So this needs to be fixed.

Expected Behavior

The main point is: the related info needs to be next to each other, as in

Actual Behavior

Using SuiteP on 7.10.0 screens for examples:

Profile screen: First and last name needs to be in the same line. Now the status info is in the middle (tab order)! fields_profile1

In the second form (employee info) fields are Z cross but phones are only in right column. So it is actually ordered as Work phone / Department / Mobile / Reports to / Other phone. IM and address are ok. fields_profile2

Employee screen First name / last name is OK but "Title / Department / Reports to" needs to be in sequence, not in the same column. Phones are mixed up, mostly on the right column but Home phone is on the left. IM and address are ok. fields_employee Note: If you want to group related fields it must be done in a different way! Even if this looks visually ok for you in a desktop, try it in a single column format (see below in the context topic)

Contacts screen Primary address and other Address are correctly placed in groups, tab order is ok (it moves top/bottom in a group then into the other group). No issues here... the pic its just to praise the work well done! That's the way to group fields and to have a proper tab order. fields_contacts

Possible Fix

Reorder layout fields in template views (edit and detail). Please verify layouts in 1 column (its a mess!)

Context

Bug low for mobile and Screen reader accessibility. Even when it looks ok for your setup, always test in a single column view. See profile screens with error caused by fields not placed in proper order: (screen reader will read something like "First name John / Status Active / Last name Doe" when the proper order should be "First name John / Last name Doe" fields_profile1_singlecol

fields_profile2_singlecol

Your Environment

Kevconry commented 1 year ago

was able to replicate in 7.13.1