search

salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.56k stars 2.11k forks source link

Create Campaigns write some errors on log file #6116

Open goncaloLopesMarques opened 6 years ago

goncaloLopesMarques commented 6 years ago

Create campaigns throw many errors on the log file

Issue

When i press the new campaign button suitecrm write in log the folling errors:

Mon Jul 2 17:44:32 2018 [2310][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:44:32 2018 [2310][1][ERROR] Unsupported segments file format

then when i press Newsletter the folling erros:

Mon Jul 2 17:45:00 2018 [2310][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:45:00 2018 [2310][1][ERROR] Unable to get proper side for link assigned_user_link

then i choose the name and the status and more errors:

Mon Jul 2 17:46:02 2018 [2310][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:46:02 2018 [2310][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:46:02 2018 [2310][1][ERROR] Unsupported segments file format

then choose the targets list and press next:

Mon Jul 2 17:46:45 2018 [2284][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:45 2018 [2284][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:45 2018 [2284][1][FATAL] SugarBean::populateDefaultValues $field_defs should be an array Mon Jul 2 17:46:49 2018 [2335][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:49 2018 [2335][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:56 2018 [2310][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:56 2018 [2310][1][ERROR] Unable to get proper side for link assigned_user_link Mon Jul 2 17:46:59 2018 [2335][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:46:59 2018 [2335][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:46:59 2018 [2335][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:47:00 2018 [2284][1][ERROR] Unable to find relationship surveys_campaigns

After choose the mail template errors

Mon Jul 2 17:48:18 2018 [2335][1][ERROR] convert: Conversion of : 12:00am from m/d/Y h:ia to Y-m-d H:i:s failed

after that

Mon Jul 2 17:49:54 2018 [2284][1][ERROR] Unable to find relationship surveys_campaigns

And finally i Scheduled the campaign and more errors

Mon Jul 2 17:51:01 2018 [2310][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:51:01 2018 [2335][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:51:01 2018 [2335][1][ERROR] Unable to find relationship surveys_campaigns Mon Jul 2 17:51:01 2018 [2284][1][ERROR] Unable to find relationship surveys_campaigns

Your Environment

Version 7.10.4 Debian GNU/Linux 9.4 (stretch) Chrome(latest version) mysql Version 14.14 Distrib 5.7.21, for linux-glibc2.12 (x86_64) php version 7.0.28

belchfireid commented 6 years ago

I have a similar problem, with this error logged each time a user selects a campaign: [ERROR] Unable to find relationship surveys_campaigns

Using Studio, I don't see the above relationship under either Campaigns or Surveys. We recently updated from SugarCRM 6.5.18 to SuiteCRM 7.10.7

westmalle commented 6 years ago

I have the same issue : this error appears in the log when I view a campaign. Sat Oct 27 15:54:28 2018 [135][1][ERROR] Unable to find relationship surveys_campaigns Version 7.10.10 Apache/2.4.6 (CentOS) OpenSSL/1.0.2k-fips PHP/7.2.11 10.1.36-MariaDB

Abuelodelanada commented 6 years ago

I found the same issue when trying to send test emails

[ERROR] Unable to find relationship emails_email_templates
[ERROR] Unable to find relationship surveys_campaigns

The relationship surveys_campaigns is not defined:

/m/d/t/SuiteCRM git:develop ❯❯❯ git grep surveys_campaigns                                                                                                                                                                    
modules/Campaigns/vardefs.php:                'relationship' => 'surveys_campaigns',

Version: SuiteCRM 7.10.10

Abuelodelanada commented 6 years ago

Hi @samus-aran @daniel-samson

Can you prioritize this issue? The test mails in campaigns are not sent.

pgorod commented 6 years ago

@Abuelodelanada are you sure? I was under the impression that everybody has this error about the missing relationship, but that it was a harmless error, with no consequences. I didn't think it was keeping emails from being sent. 🤔

pgorod commented 6 years ago

I can't do any fix now, but just for future reference I had a talk with Jim Mackin about this relationship surveys_campaigns and he's not fully sure of what is missing, says it might just be a problem with the logs, but anyway:

A label can added created in modules/Campaigns/language/en_us.lang.php like this

'LBL_CAMPAIGN_SURVEYS => 'Survey',

And the relationship that is currently referenced here https://github.com/salesagility/SuiteCRM/blob/master/modules/Campaigns/vardefs.php#L284

can (should!) be properly defined somewhere.

Abuelodelanada commented 6 years ago

Hi @pgorod !

About the missing relationship I can write the PR. What kind of relationship surveys_campaigns is? one-to-many, many-to-many ?

pgorod commented 6 years ago

Jim says that

as far as I can recall, the intention is that a campaign can only have a single survey and a survey can have many campaigns, so one to many

Thanks José!

Abuelodelanada commented 6 years ago

@pgorod I open #6549 for the missing relationship

pgorod commented 4 years ago

@Abuelodelanada can this Issue be closed?