jjwg_Maps is using a wrong google maps link

salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world

https://www.suitecrm.com

GNU Affero General Public License v3.0

4.3k stars 2.04k forks source link

jjwg_Maps is using a wrong google maps link #7447

Open diligentDE opened 5 years ago

diligentDE commented 5 years ago

Issue

markers (leads, accounts and such) are displayed on the map
if clicked, each marker contains two links ("Google Maps View", "Get Directions"):
both aren't working; they are linking to http://maps.googleapis.com/maps?saddr=some&parameters and the browser returns a 404 page

Expected Behavior

both links should use maps.google.com, for example http://maps.google.com/maps?saddr=some&parameters

Actual Behavior

both links use http://maps.googleapis.com

Your Environment

SuiteCRM Version 7.11.5

hbartel commented 5 years ago

The fix is to change the address in all the .tpl files located at /modules/jjwg_Maps/tpls/ These files are used to build the links.

/modules/jjwg_Maps/tpls/LeadsInfoWindow.tpl /modules/jjwg_Maps/tpls/InfoWindow.tpl

Tested on SuiteCRM Version 7.10.10

lhommedelecosse commented 3 years ago

To update the JJWD code, search and replace the following strings:

Google Maps View Search: maps.googleapis.com/maps?q= Replace: www.google.com/maps/search/?api=1&query=

Get Directions Search: maps.googleapis.com/maps?saddr= Replace: www.google.com/maps/dir/?api=1&origin=

Search: &daddr= Replace: &destination=

Only impacts files in the folder jjwg_Maps/tpls

pgorod commented 3 years ago

@lhommedelecosse thanks!

Better yet, move that property into the configuration file and replace every instance with a reference to it.

SuiteBot commented 2 years ago

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/google-maps-view-and-get-directions-not-working/82816/3

tsmgeek commented 2 years ago

@lhommedelecosse thanks!

Better yet, move that property into the configuration file and replace every instance with a reference to it.

While a good idea this should probably be tackled as an upgrade to use leafletjs & leaflet-geosearch and allow ability to use other search engines other than Google.

SuiteBot commented 2 months ago

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/google-maps-view-and-get-directions-not-working/82816/4