search

salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.46k stars 2.08k forks source link

Move Twitter OAuth to Composer, or remove it entirely #7595

Open connorshea opened 5 years ago

connorshea commented 5 years ago

We seem to use this package: https://github.com/abraham/twitteroauth

It's in `include/social/twitter/twitter_auth/: https://github.com/salesagility/SuiteCRM/blob/0b7909a5e63810170cf81a744ef849d03b1291c4/include/social/twitter/twitter_auth/

Based on this line, the 0.2.0-beta2 version, though that doesn't seem right because 0.2.0-beta2 came out in December of 2009: https://github.com/salesagility/SuiteCRM/blob/0b7909a5e63810170cf81a744ef849d03b1291c4/include/social/twitter/twitter_auth/twitteroauth/twitteroauth.php#L35

Surprisingly, Twitter is still on the same API version (1.1) so I think it might still work?

If it doesn't actually work, we should probably just remove this functionality entirely since it doesn't seem anyone is using it. Ditto for the Facebook integration.

connorshea commented 5 years ago

Based on https://github.com/salesagility/SuiteCRM/issues/2914 and https://github.com/salesagility/SuiteCRM/issues/2644, neither Twitter nor Facebook integration works. I'd say the best course of action is just to remove them unless someone wants to step up, fix them, and move the packages to Composer.

connorshea commented 5 years ago

@isleshocky77 I know you've mentioned being interested in this functionality, do you want to fix it or should we remove it?

isleshocky77 commented 5 years ago

I would like the feature of working with twitter, but I have no idea what this does and I'm guessing if someone were to do it now they would do it completely differently. I would say just remove it all together and it could always be added back when done properly.

I think I had more mentioned it because I was trying to do something similar with an internal API.

pgorod commented 5 years ago

I'm not optimistic about this idea of removing features - we have no way of knowing how many people are using it, and how important it is to them. Sometimes I see people mentioning these features on the Forums. Maybe it's not broken for everybody?

connorshea commented 5 years ago

@pgorod just based on my understanding of the Twitter API's various breaking changes over the years and the fact that this package is so old, I'd be incredibly surprised if it actually works today. I'd be happy to see evidence suggesting otherwise, though.

chris001 commented 5 years ago

Version 1.01 released in 2019: https://packagist.org/packages/abraham/twitteroauth

chris001 commented 8 months ago

Current version 6.2.0, released 2023-10-28!