search

salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.55k stars 2.1k forks source link

Lato font overwritten with zero byte files on each upgrade #8175

Open mattf10 opened 5 years ago

mattf10 commented 5 years ago

The upgrade packages, e.g. SuiteCRM-Upgrade-7.10.x-to-7.10.21.zip have zero byte files for all Lato fonts in the directory /themes/SuiteP/fonts. See forum post for details: https://suitecrm.com/suitecrm/forum/installation-upgrade-help/27003-lato-font-overwritten-with-zero-byte-files-on-each-upgrade

Issue

After each upgrade, files must be downloaded and copied to filesystem or else the system uses the wrong fonts.

Expected Behavior

Existing font files should not be replaced with zero byte versions.

Actual Behavior

Files are replaced with zero byte files.

Possible Fix

Font files in upgrade packages should be replaced with files that contain data instead of empty files.

Steps to Reproduce

  1. Go to Admin -> Upgrade Wizard.
  2. Upload package from SuiteCRM repository
  3. When upgrade completes, system displays the incorrect font since it is unable to load Lato fonts.

Context

This is a minor annoyance but a 2 second fix, so should be done for the next upgrade.

Your Environment

This is not related to the system environment since the problem is in the upgrade packages themselves.

pgorod commented 5 years ago

This issue has a long history...

5915

7331

7751

Something is causing this to break repeatedly after we fix it :-(