salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.45k stars 2.08k forks source link

[7.10.X] Mail reply sends attachment from original mail ALWAYS #8602

Open fcorluka opened 4 years ago

fcorluka commented 4 years ago

Issue

When trying to reply to mail, CRM automatically sets attachment from the original mail. When I don't want this attachment a can click on X button and it is visually gone. But when mail is sent, the receiver gets the mail with attachment !!

Expected Behavior

If the mail does not have attachment one should not be sent from a parent.

Actual Behavior

Sends not regarding the mail.

Possible Fix

This I believe is an architectural problem with mails. A reply mail is initially DRAFT but it is not a new bean, it is the same original mail (id is the same, issue #8554). I see that in earlier version there was a problem with delete of attachment (issue #5520), and now I can not delete one.

Steps to Reproduce

  1. open mail with an attachment, and reply to it
  2. in reply check if the original attachment is automatically in the mail
  3. delete the attachment and send email
  4. check your mailbox - there should be mail with attachment

Context

I am sending mail totally wrong, in a totally wrong way with attachments I do not want!

Your Environment

pgorod commented 4 years ago

@fcorluka if you can please edit your post and add a hash before the numbers of the other Issues you mention, Github will recognize it and cross-link everything, which is very useful.

Thanks for opening this issue.

fcorluka commented 4 years ago

Anyone tried to test this?

Mac-Rae commented 4 years ago

Hi @fcorluka,

This issue has been confirmed to exist and is replicable in the latest 7.10.x version.

Thanks :+1:

dickeytsang commented 4 years ago

Anyone tried to test this?

Me, same issue on version 7.11.12; any suggestion?

tsmgeek commented 4 years ago

https://github.com/salesagility/SuiteCRM/pull/8715

This fixes some issues with creating new messages based of a received message. It may help.

SuiteBot commented 3 years ago

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/emails-with-attachments-when-replied-sends-all-attachments-even-after-removing/80519/2

clemente-raposo commented 2 years ago

Hi @Mac-Rae,

I tried to reproduce this issue in the latest hotfix branch (7.12.x at the moment) and wasn't able to reproduce.

However, I noticed that when you click on on the modal that says "Email sent" you stay on the reply edit, instead of going to the list view.

@Mac-Rae could you try to reproduce, please?

These are the steps I did in order to try to reproduce:

  1. Send email with attachment using external mail client image

image

  1. Open email in Suite emails module image

image

  1. Click reply image

  2. Remove the attachment by clicking the 'X' on the left of the attachment image

image

  1. Add some text to the response body image

  2. Send email image

image

  1. Check email in Suite, no attachements image

image

  1. Check email in external mail client, no attachment image
clemente-raposo commented 2 years ago

Hi @tsmgeek, @fcorluka, @pgorod

I've created the following MR, to fix some issues in email message modal: https://github.com/salesagility/SuiteCRM/pull/9393

Please have a look at the description for more details

Mac-Rae commented 2 years ago

Can confirm this Issue appears to hold over into 7.12.2 & 8.0.1 however the secondary issues related have been resolved with the lastest pushes.

Pressing reply on an email and removing the attachment by pressing the X on the purple token will still send an email with attachment when hitting send. We will continue to investigate this issue and update when we can :+1: