New User Password emails do not replace variables with user information

[mikek03]

SuiteCRM provides a function to generate a password and email the user on new user account creation. The email that is sent is configured in Admin->Password Management under Email Templates->For system-generated password. I've used the "Edit" button to edit the predefined template and wish to include an element of personalisation, addressing the email Dear UserLastName but when insering the variable for either User Last Name (which generates $contact_user_last_name) or Employee Last Name (which generates $employee_last_name), it does not get replaced when the email is sent.

Expected Behavior

When editing the email template for "system-generated password", I place custom text including variables for $contact_user_first_name or other $contactuser..... variables. When SuiteCRM sends the new user the email, these should be replaced with the user's information, for example if I place Dear $contact_user_first_name in the template, the email should say "Dear Mike".

Actual Behavior

When the email is delivered, it simply reads "Dear $contact_user_first_name", the variable is not replaced during send.

Steps to Reproduce

1. Go to "Admin"
2. Go to "Password Management
3. Ensure that the "Enable System-Generated Passwords Feature" is checked
4. Go to the Email Templates Section
5. Click the "Edit" button next to the system-generated passwords option
6. Amend the email text to include "Dear $contact_user_first_name,"
7. Save all settings
8. Create a new user without specifying a password, ensuring to set the First Name.
9. Check the email received, the text reads "Dear $contact_user_first_name," instead of the value specified in the user First Name field.

Context

Trying to onboard a number of users for a system hosted on behalf of a client. The users are suspicious about receiving an email that is not personalised.

Your Environment

• SuiteCRM Version used: Version 7.11.13 (Sugar Version 6.5.25 (Build 344))
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): 85.0.4183.102 (Official Build) (64-bit) on Mac OS Also all browsers on all operating systems i've been able to try including Windows, Linux, Chrome, IE, Edge, Firefox.
• Environment name and version (e.g. MySQL, PHP 7): MariaDB 5.5.65, Apache 2.4.6 PHP 7.3.22
• Operating System and version (e.g Ubuntu 16.04): Centos 7 (Red Hat Enterprise Linux Server 7.8)

[pgorod]

Workaround is to add variables in blocks like these here https://github.com/salesagility/SuiteCRM/blob/master/modules/Users/User.php#L2301

   $htmlBody = str_replace('$contact_user_first_name', $this->first_name, $htmlBody);
   $body = str_replace('$contact_user_first_name', $this->first_name, $body);

The fields are from User beans, not contact beans.

A proper fix is to make this code use full template parsing capabilities.

[mikek03]

Thanks @pgorod, that works perfectly.

[pgorod]

Glad to hear it, but please reopen the issue, this is not fixed yet ;-)