search

salesagility / SuiteDocs

SuiteCRM - Open source CRM for the world
https://docs.suitecrm.com/
Other
60 stars 287 forks source link

Fix levels in links #641

Closed pgorod closed 7 months ago

pgorod commented 7 months ago

Broken links. These are probably showing in htmltest output, but maybe nobody's paying attention to broken links in Docs?

12:00:30 PM: ========================================================================
12:00:30 PM: ✘✘✘ failed in 1.326539402s
12:00:30 PM: 848 errors in 429 documents
12:00:30 PM: ---------------------------------------------------------
12:00:30 PM:       1 
12:00:30 PM:     543 hash does not exist
12:00:30 PM:     271 src attribute empty
12:00:30 PM:      33 target does not exist
12:00:30 PM:       1 href blank

This output should be clean..., especially the "33 target does not exist" (after this PR fixed a few of them)

I suggest that looking carefully at the htmltest output in Netlify (build log) should be a part of merging PRs into Docs.

PRs should not be merged if they worsen the error count. Ideally, the error count is brought down to zero, and so the rule changes to "PRs should not be merged if the error count is not zero".

SuiteBot commented 7 months ago

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/email-signature-not-loading-correctly-or-at-all/91572/15

serhiisamko091184 commented 7 months ago

Hi @pgorod,

thanks a lot for your changes!

Regards, Serhii