salesforce-marketingcloud / FuelSDK-PHP

FuelSDK-PHP
MIT License
134 stars 142 forks source link

[BUG] php8.0 or upper #177

Closed chanchunctwo closed 1 year ago

chanchunctwo commented 1 year ago

Describe the bug main.CRITICAL: Exception message: Deprecated Functionality: Creation of dynamic property FuelSdk\ET_TriggeredSend::$folderProperty is deprecated in /bitnami/magento/vendor/rizhk/fuel-sdk-php/src/ET_TriggeredSend.php on line 27 Trace:

#1 FuelSdk\ET_TriggeredSend->__construct() called at [vendor/pernod-ricard/magento-mod-pr_marketing_cloud/Framework/Sfmc/Network.php:165]

To Reproduce Its affect marketing cloud feature using M2.4.6

Expected behavior It should be compatible to new php version

Code snippet You should always add their variables as public or protected when construct them in class like ET_TriggeredSend.php, please also check others as well.

protected $folderProperty ;
protected $folderMediaType;

    function __construct()
    {
        $this->obj = "TriggeredSendDefinition";
        $this->folderProperty = "CategoryID";
        $this->folderMediaType = "triggered_send";
    }

Note: Because the developers need to copy and paste the code snippet, including a code snippet as a media file (e.g. gif) is not sufficient.

Environment

  • PHP version 8.2.8